Possible Excel export bug found in 'buttons.html5.js' v1.6.4

cavedave

Uncaught TypeError: a[b].trim is not a function

Attached are the console logs with error from using 1.6.4 buttons.html5.min.js & buttons.html5.js

I attempted the same Excel export with versions 1.6.3, 1.6.2 and 1.6.1 and they were all successful.

cavedave

I just noticed, there are differences between the code on github and the code loaded via cdn. Do you know why the code would be different?

https://github.com/DataTables/Dist-DataTables-Buttons/blob/master/js/buttons.html5.min.js
var h=a[b];a[b]=j.trim(a[b]);

https://cdnjs.cloudflare.com/ajax/libs/datatables-buttons/1.6.4/js/buttons.html5.min.js
var h=a[b];a[b]=a[b].trim();

https://github.com/DataTables/Dist-DataTables-Buttons/blob/master/js/buttons.html5.js
row[i] = $.trim( row[i] );

https://cdnjs.cloudflare.com/ajax/libs/datatables-buttons/1.6.4/js/buttons.html5.js
row[i] = row[i].trim();

allan

Hi,

The fix is in the nightly. We just need to tag it up and release it. I'll be doing that before the end of the week.

Allan

cavedave

Thanks for your quick response!