Answers

• tangerine Posts: 3,365Questions: 39Answers: 395

  July 2021

  var minDate, maxDate;

  Is your code initialising those variables?
• tangerine Posts: 3,365Questions: 39Answers: 395

  July 2021

  Sorry, I meant "defining".
• colin Posts: 15,240Questions: 1Answers: 2,599

  July 2021

  We're happy to take a look, but as per the forum rules, please link to a test case - a test case that replicates the issue will ensure you'll get a quick and accurate response. Information on how to create a test case (if you aren't able to link to the page you are working on) is available here.

  Cheers,

  Colin
• phil_c64 Posts: 8Questions: 2Answers: 0

  July 2021 edited July 2021

  Hi Tangerine,

  I copied the code "as is" from the demo into https://form.kingfisher.design/wp-content/themes/formidable/js/dataTables-searchDate.js

  The full snippet is as the following so minDate, maxDate are being defined in the document.ready function below it.

  I'm slightly confused as to why all the syntax isn't in the document.ready as it didn't look right to me but I'm veyr much still learning js.

  var minDate, maxDate;
  
  // Custom filtering function which will search data in column four between two values
  $.fn.dataTable.ext.search.push(
      function( settings, data, dataIndex ) {
          var min = minDate.val();
          var max = maxDate.val();
          var date = new Date( data[4] );
  
          if (
              ( min === null && max === null ) ||
              ( min === null && date <= max ) ||
              ( min <= date   && max === null ) ||
              ( min <= date   && date <= max )
          ) {
              return true;
          }
          return false;
      }
  );
  
  jQuery(document).ready(function($) {
  
      // Create date inputs
      minDate = new DateTime($('#min'), {
          format: 'MMMM Do YYYY'
      });
      maxDate = new DateTime($('#max'), {
          format: 'MMMM Do YYYY'
      });
  
      // Refilter the table
      $('#min, #max').on('change', function () {
          table.draw();
      });
  
  } );
  

  Thanks for your time
• allan Posts: 63,498Questions: 1Answers: 10,471 Site admin

  July 2021

  Try changing the $ to jQuery. It could be that you've released the $ variable (jQuery.noConflict() for example).

  The search function isn't in document.ready because it doesn't depend upon the DOM being ready. It just gets added to the array (.push(...)) and is only then actually executed when the DataTable is initialised (which will happen when the document is ready).

  Allan
• phil_c64 Posts: 8Questions: 2Answers: 0

  July 2021

  Hi Allan,

  Thanks for the explanation too. Tried jQuery instead but it's still throwing a hissy fit!

  Can give you admin access if you don't mind if quicker.
• phil_c64 Posts: 8Questions: 2Answers: 0

  July 2021

  Moved inside the document.ready and it's now not showing the same error. But doesn't work. I suspect a date format mismatch.

  var minDate, maxDate;

  jQuery(document).ready(function($) {
  
      $.fn.dataTable.ext.search.push(
          function( settings, data, dataIndex ) {
              var min = minDate.val();
              var max = maxDate.val();
              var date = new Date( data[4] );
  
              if (
                  ( min === null && max === null ) ||
                  ( min === null && date <= max ) ||
                  ( min <= date   && max === null ) ||
                  ( min <= date   && date <= max )
              ) {
                  return true;
              }
              return false;
          }
      );
  
      // Create date inputs
      minDate = new DateTime($('#min'), {
          format: 'MMMM Do YYYY'
      });
      maxDate = new DateTime($('#max'), {
          format: 'MMMM Do YYYY'
      });
  
      // Refilter the table
      $('#min, #max').on('change', function () {
          table.draw();
      });
  
  } );
  
• colin Posts: 15,240Questions: 1Answers: 2,599

  July 2021

  Please can you create a test case. See my reply above for instructions on how to do that,

  Colin
• phil_c64 Posts: 8Questions: 2Answers: 0

  July 2021

  Hi Colin,
  Sorry i didn't see your earlier reply hence me replying afterwards

  I have got this fixed and will post asap once it's ready