Resharper

Resharper

ImpPhilImpPhil Posts: 12Questions: 4Answers: 0

Resharper show 11 errors for data tables and a lot of warnings.
Maybe something to look at?

This question has an accepted answers - jump to answer

Answers

  • allanallan Posts: 63,783Questions: 1Answers: 10,511 Site admin

    Is this in the DataTables.dll, or somewhere else? What are the errors please?

    Allan

  • ImpPhilImpPhil Posts: 12Questions: 4Answers: 0
    edited March 2016

    7 errors in buttons.dataTables.css

    e.g. background-image: linear-gradient(top, white 0%, #e9e9e9 100%);
    it doesn't like the use of 'top' which gives an error
    Expected one of: <angle>, to, <named-color>, <system-color>, <color>, rgb(), rgba(), hsl(), hsla().

    '0%' gives a warning. Apparently best practice is to use 0.
    Lots of other warnings.

    Error in rowReorder.boostrap (or datatables or foundation or jqueryui).css
    Doesn't like table-layout: static
    Expected one of: auto, fixed, inherit.

  • allanallan Posts: 63,783Questions: 1Answers: 10,511 Site admin

    Awesome - thanks!

    Editor has a few as well which I'll commit in a moment.

    Looks like a need to lint the CSS the same way I do the JS!

    Allan

  • ImpPhilImpPhil Posts: 12Questions: 4Answers: 0

    Why don't you get Resharper? They'll give you a free copy https://www.jetbrains.com/buy/opensource/

  • ImpPhilImpPhil Posts: 12Questions: 4Answers: 0

    I think your rowReorder fix needs to fix rowReorder.datatables.css etc as well.

  • allanallan Posts: 63,783Questions: 1Answers: 10,511 Site admin
    Answer ✓

    I use Sublime Text, which as far as I am aware, ReSharper doesn't work with.

    The RowReorder fix was in the .scss file. The .css files are built from that. The nightly files should be up to date with that change.

    Allan

This discussion has been closed.