Edit single item and bubble editing not working for multiEditable set to false

angekouf

In my datatable I have enabled both bubble editing and editing a single or multiple items after selection with main editing form.

If I disable multiEditable in a field, the field works only when clicking new button.
When I select a single item and click edit the field for which multiEditable has been disabled says that the input can only be edited individually. Is taht normal? Can i specify tomehow to the editing form that only a sinlge element is selected and why do i need to do that since the datatable knows how many elements have been selected anyway?
Even if I try to use bubble editing it says the same, even though bubble editing is by default for changing a single cell. Why?

For now I have left multiEditable enabled to avoid these issus but I would appreciate it if you could point me to the right direction.

allan

Hi,

Could you possibly post a link too the page showing the issue please? I'm having trouble picturing this in my mind at the moment!

Regards,
Allan

angekouf

I uploaded the page. http://tests.southcrete.gr/office/contacts
I have disabled multiEditing for email. Try to use bubble edit or select an item and edit it.

allan

Thank you. This is a bug for certain. I'm tracking it down just now and will send you an updated file with the fix tomorrow morning.

Regards,
Allan

allan

Apologies, I've not been well today and haven't been able to work on the fix. I will have it done tomorrow for sure and send it over then.

Allan

angekouf

Ok. Thank's a lot. Hope you get better soon.

Soory to impose, but could you also tell be why the datepicker does not show in 'Date of Birth' field when clicking new or edit, but works porperly on bubble editing?

allan

Thanks - feeling much better today .

I've just sent you a PM with an updated version of Editor that should resolve this issue. for multi editing.

why the datepicker does not show in 'Date of Birth' field when clicking new or edit

It looks like a z-index issue. The modal is on top of the date picker. If you use:

div.editor-datetime {
  z-index: 11001;
}

in your CSS, that will resolve that issue.

Allan

angekouf

Thank you allan. Everything works properly now.
I knew the datepicker was something idiotic on my part but could not figure out what...
Thanks a great deal for your help.

sliekens

Allan, could you share the fix? I'm also having problem getting fields.multiEditable to work.

allan

I've just sent it over via PM. I'll be doing an Editor release next week with all the latest fixes.

Allan

Flashdown

Looks like it's still not fixed in 1.6.2
Can I have the fixed version, please?

Flashdown

I just noticed an odd piece of code, could you please check if that's a bug:

    isMultiValue: function () {
        return this.s.multiValue && this.s.multiIds !== 1;
    },

Shouldn't it be this.s.multiIds.length ?

allan

Yes - I believe you are correct. I'll run some tests on that shortly, but I think it should be.

Does it work for you locally if you make that change (I'm not at my dev machine at the moment).

Regards,
Allan

Flashdown

Unfortunately, it doesn't solve the issue, so I'm still looking forward to getting a fix from you.

Flashdown

After upgrading to 1.6.2 I'm also running into an issue with the submit: 'changed' option, it doesn't seem to be working; the form submits the values which even weren't touched.

Flashdown

I had to downgrade to 1.6.1 which did the trick, but still don't know what to do with the multiedit issue.

allan

Are you able to give me a link to a test case showing that issue please? This example uses submit: 'changed' and it appears to work as expected.

Thanks,
Allan

Flashdown

Here you are:
http://live.datatables.net/mosubezi/1/

Click on the empty space in the last column, input some value and click outside the field, and keep track of the AJAX request. You'll notice that the value of the second column is also submitted though it was not edited.
Please notice that the issue doesn't exist in 1.6.1

allan

Hi,

Fantastic - thanks for the test case!

The issue is being caused by strict type checking. In the data being loaded from the server the price values are Number types (e.g. 10.5), while when Editor reads then back from the input element it reads them as a string (e.g. "10.5").

1.6.1 didn't do strict type checking, but 1.6.2 does, which means that these values appear to be different and hence why they are submitted. If you change price1_value to be a string ("price1_value": '10.5',) it will submit only price2 as expected.

You can restore the loose type checking by finding:

else if (o1[propName] !== o2[propName]) {

in the Editor source and changing it to be:

else if (o1[propName] != o2[propName]) {

I'm honestly not sure if I consider this to be a bug or not! The data is different, so technically it is correct, but I can also see that it might be unexpected.

I'll have a think about it!

Regards,
Allan

Flashdown

Thanks for looking into that.
In this case it would make sense to explicitly point out in the docs that the data returned from the server should be in the text format.

Were you able to reproduce the issue with multi-editing or it works fine for you?

allan

Sorry I must confess I lot track of that one. I've added it to my log to look into it now and will get back to you.

Allan

sliekens

Allan, the issue with fields.multiEditable still exists in Editor 1.6.3.

Instead of trying to get the community to submit code that doesn't work, could you please create an example with code that does work as intended?

sliekens

Here's an example of multiEditable that doesn't work: http://live.datatables.net/yozotoyi/2/edit?js,output

Select a row and click the Edit button. Observe that First Name and Last Name are incorrectly disabled.

allan

My apologies - yes, there is a bug there. Thank you for the test case. I fear I might have inadvertently added that in 1.6.3. Same result, different cause and I missed it.

Allan

sliekens

No problem. Will it be in the next release? It's one of our most wanted features because we have many tables with unique constraints.

allan

Yes it will be. I'm also going to add an example to the live examples list. I'm not sure when 1.6.4 will be released yet, but I'll update this thread when its done.

Allan

allan

Quick update - this has been committed now and the multi-row editing example updated to include use of fields.multiEditable. 1.6.4 will short in the next couple of days.

Allan

frenkie.smart

Hi allan

I just tried V1.6.4, 1.6.5 and also the latest, but the error seems to exist. And also on the latest version, which is 1.9.1.

allan

Hi @frenkie.smart. Could you give me a link to a page showing the issue please? It appears to work in this example.

Allan