Standalone inline editing example is broken

bg7

Link to test case:
https://editor.datatables.net/examples/standalone/inline.html

Description of problem:
The standalone inline editing example no longer works. I'm guessing it's because of the update to the Editor2 release as this example used to work. When you click on a field to edit the error in the console is:

Uncaught TypeError: editRow[a86] is undefined

I tried to set up a live.datatables.net example but got the same console error.

I'm wondering, once this is working again, is it possible to activate all the fields for editing at once? It would be great if they could optionally all render as the input widgets at the same time. According to this:

https://editor.datatables.net/reference/api/inline()

it can be done for all the cells in a row and I'm wondering if that can be applied to a row of data laid out as is done in this standalone inline example.

Thanks.

Ben

bg7

I tried that example in live.datatables.net and I get the same error:

http://live.datatables.net/beleloni/2/edit

I also tried it in my environment and get a different error. I stripped down the example code to be as simple as possible:

HTML:

<dl>
    <dt>Name:</dt>
    <dd data-editor-field="name">test name</dd>
</dl>

JavaScript:

let editor = new $.fn.dataTable.Editor({
    fields: [
        {
            label: 'Name:',
            name: 'name',
        }],
});

$('*[data-editor-field]').on('click', function () {
    editor.inline(this);
});

When I run it I get this error instead:

Uncaught TypeError: editRow.attachFields is undefined

I don't think I can make that example much simpler. Am I completely missing something?

Thanks.

Ben

allan

Hi Ben,

No you haven't missed anything - it looks like we missed a bug in Editor 2 unfortunately. I'm looking into it at the moment and will post back shortly when I know what is causing it.

Allan

allan

Hi,

I've just committed the fix for this and it will be in Editor 2.0.2 which I'll drop next week to get this out. If you need it sooner, let me know and I'll package up trial of the dev version for you.

Allan

bg7

Allan,

We ended up going with a different solution instead. I stumbled across this in your blog by accident:

https://datatables.net/blog/2017-06-30

and figured out how to embed the editor wherever which is perfect for us.

Thanks.

Ben