After an inline edit, the edited row dissapears

matt_rumsey1212

On one of my pages I have two tables, when a user selects an entry from the first table it loads information into a second using a query string which is sent back to the controller. When I inline edit a basic select box on the second table the data is submitted correctly and updated. However, the updated row is removed from the view until the ajax call is made again. Further to this I do a similar thing on a different page within my application and it works perfectly without removing the row after an update. Any help would be appreciated.
Below is the javascript related to this

//USER PERMISSIONS EDITOR
       /*
       * Populates the Editor with fields (create, edit) for the User Permissions List
       */
        var editorThree = new $.fn.dataTable.Editor({
            ajax: "/NewUser/UserAssignedPermissionsTable",
            table: "#UserCampaignPermissions",
            fields: [
                {
                    "label": "Permission",
                    "name": "CampaignPermissions.Permission_id",
                    "type": "select"
                },
                {
                    "label": "Campaign",
                    "name": "CampaignPermissions.Campaign_id",
                    "type": "select"
                }
            ]
        });

//USER LIST TABLE
        /*
        * Populates the user list table
        */
        var table = $("#UserList").DataTable({
            ajax: "/NewUser/UserListTable",
            select: {
                style: "single"
            },
            scrollY: "550px",
            pageLength: 25,
            processing: true,
            //stateSave: true,
            columns: [
                {
                    "data": "ClientUserLink.Id",
                    "visible": false
                },
                {
                    "data": "U.Username",
                    "className": "Inline"
                }
            ]
        });

//ASSIGNED CAMPAIGNS/PERMISSIONS TABLE
        /*
        * Populates the Permissions table
        */
        tableThree = $("#UserCampaignPermissions").DataTable({
            ajax: "",
            select: {
                style: "single"
            },
            processing: true,
            //scrollY: "200px",
            paging: false,
            searching: false,
            columns: [
            {
                "data": "CampaignPermissions.User_id",
                //"visible": false
            },
            {
                "data": "CampaignPermissions.Id",
                "visible": false
            },
            {
                "data": "Campaign.Name",
                "editField": "CampaignPermissions.Campaign_id"
            },
            {
                "data": "Permissions.Permission",
                "editField": "CampaignPermissions.Permission_id"
            }
            ]
        });

        $("#UserCampaignPermissions").on("click", "tbody td:not(:first-child)", function (e) {
            editorThree.inline(this, {
                onBlur: "submit"
            });
        });

//RELATED FUNCTIONS
        /*
        * Loads data in the second table (Assigned Role) and third table (PERMISSIONS) when a team is selected within
        * the user list
        */
        $("#UserList tbody").on("click", "tr", function() {
            var selectedRows = table.rows({ selected: true }).count();
            if (selectedRows === 1) {
                currentUserId = table.row(this).data().ClientUserLink.User_Id;
                tableTwo.ajax.url("/NewUser/UserAssignedRolesTable/?userId=" + currentUserId).load();
                tableThree.ajax.url("NewUser/UserAssignedPermissionsTable/?userId=" + currentUserId).load();
            } else if (selectedRows === 0) {
                tableTwo.clear().draw();
                tableThree.clear().draw();
            }
        });

matt_rumsey1212

Is there a way of forcing the table to redraw after submit?

allan

If the row is disappearing it means the server isn't responding with the expected JSON.

What is it currently responding with?

Allan

matt_rumsey1212

The response contained no data. Which is understandable as the editor Ajax URL is not modifiable by a query string. I have now modified the controller to store the current query string as a static variable so that whenever editor makes a call (sending the query string "NONE") it returns json relevant to the whatever DataTables is displaying.

Controller is now as follows:

public ActionResult UserAssignedPermissionsTable(string userId)
        {
            if (userId != "NONE")
            {

                if (userId != null)
                {
                    currentUserGuid = new Guid(userId);
                }
                else
                {
                    var bytes = new byte[16];
                    currentUserGuid = new Guid(bytes);
                }
                var formData = HttpContext.Request.Form;

                using (
                    var db = new Database("sqlserver",
                        WebConfigurationManager.ConnectionStrings["Uwfm"].ConnectionString))
                {
                    var response = new Editor(db, "[dbo].[CampaignPermissions]")
                        .Model<PermissionsModel>()
                        .Field(new Field("CampaignPermissions.User_id")
                        )
                        .Field(new Field("CampaignPermissions.Campaign_id")
                            .Options("[dbo].[Campaign]", "Id", "Name")
                        )
                        .Field(new Field("CampaignPermissions.Permission_id")
                            .Options("[dbo].[Permissions]", "Id", "Permission")
                        )
                        .LeftJoin("[dbo].[Campaign]", "Campaign.Id", "=", "CampaignPermissions.Campaign_id")
                        .LeftJoin("[dbo].[Permissions]", "Permissions.Id", "=", "CampaignPermissions.Permission_id")
                        .Where("CampaignPermissions.User_id", currentUserGuid)
                        .Where("Campaign.Client_id", ClientContext.Current.ClientId)
                        .Process(formData)
                        .Data();

                    return Json(response, JsonRequestBehavior.AllowGet);
                }
            }
            else
            {
                Debug.WriteLine("Editor" + currentUserGuid);
                var formData = HttpContext.Request.Form;

                using (
                    var db = new Database("sqlserver",
                        WebConfigurationManager.ConnectionStrings["Uwfm"].ConnectionString))
                {
                    var response = new Editor(db, "[dbo].[CampaignPermissions]")
                        .Model<PermissionsModel>()
                        .Field(new Field("CampaignPermissions.User_id")
                        )
                        .Field(new Field("CampaignPermissions.Campaign_id")
                            .Options("[dbo].[Campaign]", "Id", "Name")
                        )
                        .Field(new Field("CampaignPermissions.Permission_id")
                            .Options("[dbo].[Permissions]", "Id", "Permission")
                        )
                        .LeftJoin("[dbo].[Campaign]", "Campaign.Id", "=", "CampaignPermissions.Campaign_id")
                        .LeftJoin("[dbo].[Permissions]", "Permissions.Id", "=", "CampaignPermissions.Permission_id")
                        .Where("CampaignPermissions.User_id", currentUserGuid)
                        .Where("Campaign.Client_id", ClientContext.Current.ClientId)
                        .Process(formData)
                        .Data();

                    return Json(response, JsonRequestBehavior.AllowGet);
                }
            }
        }

This has meant the response comes back as follows when performing an inline edit:

{"draw":null,"data":[{"DT_RowId":"row_4","CampaignPermissions":{"User_id":"0fde13bc-e79d-492b-aca8-a04b011187f9","Campaign_id":"ef65568a-11d8-4d33-b866-a45a00df1d58","Permission_id":1,"Id":4},"Permissions":{"Permission":"Read                     "},"Campaign":{"Name":"Demo SalesandService","Client_id":"35028146-0ed8-47b2-a072-a04b00c236fd"}}],"recordsTotal":null,"recordsFiltered":null,"error":null,"fieldErrors":[],"id":null,"meta":{},"options":{},"files":{},"upload":{"id":null}}

The above information matches up correctly, however; now the change is not applied to the record in the database at all...

I realise this can be cut down to shorter code. Felt easier to explain this way though.

gudladona87

I am having a similar issue.. Were you able to solve this problem..?

matt_rumsey1212

No still no luck with it unfortunately. Having another go now.

allan

Just to check my understanding - the only change you made was to have JSON data in the response for the inline edit, but now the write to the database is not happening (presumably it was before)?

What exactly what the change that was made?

Allan

matt_rumsey1212

I just edited the controller so that the ajax URL used by Editor returned data. Prior to this it was trying to execute the Where statement...

.Where("CampaignPermissions.User_id", currentUserGuid)

...without a valid Guid due to it not making use of the query string in the actionresult method

I have since then also turned on the editor form, for creating a record (using "editorTwo.create..."), on my JS file and received a "object is not set to an instance of an object" error as well. Although I can't for the life of me work out why.

allan

We should perhaps address the need to send the user id - I would suggest using both the DataTables ajax.data and the Editor ajax.data options as functions to add the data needed:

ajax: {
  url: ...,
  data: function ( d ) {
    d.User_id = user_id; // a variable that can be accessed and contains the correct id
  },
  type: 'POST' // only needed for DataTables, Editor is POST by default
}

I'm not convinced that will solve the problem of the database not updating - but if the only change was the removal of the Where condition, then perhaps it will.

Allan

matt_rumsey1212

Awesome; I will try this as soon as possible and get back to you. About to head out for a work Christmas meal so may not be until a bit later. Thank you as always!

matt_rumsey1212

So you were right, that did not solve the database updating. I created some buttons (create,edit) for the purposes of testing. When I hit the create button on the form I receive the following:

"Object reference not set to an instance of an object."

allan

From the server, or in the Javascript? What is the code that is failing? If its in the server you might need to add TryCatch( false ) to the Editor initialisation so it will show exactly where the exception is occurring.

Allan

matt_rumsey1212

Appears to be the server, response preview is:

{draw: null, data: [], recordsTotal: null, recordsFiltered: null,…}
data: []
draw: null
error: "Object reference not set to an instance of an object."
fieldErrors: []
files: {}
id: null
meta: {}
options: {}
recordsFiltered: null
recordsTotal: null
upload: {id: null}

allan

Did you try adding the TryCatch( false ) to allow it to break where the error actually is? It should be the first item in the chain.

Allan

matt_rumsey1212

Line 76: var response = new Editor(db, "appUserConfig.CampaignPermissions", "Id")

After setting TryCatch to false it seems the above has been revealed as whats causing the error.

matt_rumsey1212

Aha! So I'm wondering if its to do with im handling schemas? Is there anyway of me changing the schema that is searched for?

allan

It points to that line rather than something inside the Editor class?

It might well be a schema issue - that isn't currently a feature that is supported by the Editor classes I'm afraid.It is something I have actively been looking at adding explicit support for though.

Allan

matt_rumsey1212

Yeah, I checked it as well by recreating the table as a "dbo." table and the problem disappeared.