Bug in latest version of responsive extension

Bug in latest version of responsive extension

rf1234rf1234 Posts: 1,770Questions: 51Answers: 259
edited May 19 in Responsive

Link to test case: https://datatables.net/extensions/responsive/examples/initialisation/option.html
Debugger code (debug.datatables.net):
Error messages shown:
Description of problem:
As you can see in the example when paging through the data table the child row button is no longer shown on the second page so that you can't make the child rows visible any longer. Once you change the screen size the child row buttons come back. But not with normal paging. This used to work perfectly before - but not any longer. I use the latest version of Chrome for Windows 10 and Responsive version 2.2.4.

Here is a screenshot of the first page:

The second page looks weird: only 2 of the 10 rows have the responsive button, the rest doesn't (on my own page it is zero by the way):

Now I resize the browser for the second page - and everything is ok again (same on my own page):

It would be great to get some kind of hot fix - otherwise I will have to move back to the previous release which means accepting the bug in responsive.hasHidden again.

Many thanks for your support!

Replies

  • kthorngrenkthorngren Posts: 10,675Questions: 25Answers: 2,438

    Sounds like the issue discussed in this thread.

    Kevin

  • rf1234rf1234 Posts: 1,770Questions: 51Answers: 259
    edited May 19

    Yes, Kevin. I tried to modify the code according to Allan's fix here:
    https://github.com/DataTables/Responsive/commit/f8381497571ca6c1b0b1ad082b3c18e1fa0b94fe

    Since I am using the download builder I have to integrate all of this into the file "datatables.js" and subsequently minify it. This file contains all of the extensions as well including Responsive.
    The minifying failed. Now I am stuck ...
    I don't even know whether the fix is already in the nightly version. Since I have never installed nightly versions I don't even know how to install them either. Just downloading them won't help I guess because I need to integrate them into the file "datatables.js" that contains everything including all of the extensions ...

    Too late for all of this today ...

  • rf1234rf1234 Posts: 1,770Questions: 51Answers: 259
    edited May 19

    Since this bug is so serious I can only hope for a new release of Responsive to be integrated into the download builder as soon as possible. @allan, it would be great if this could be done ... I can't remove "Responsive" not even temporarily. Please help. I need to come up with a solution tomorrow ...

  • kthorngrenkthorngren Posts: 10,675Questions: 25Answers: 2,438

    Open the datatables.js file and there will be a link to update the file. Go to the link, remove Response and download the new, temporary datatables concatenated files. Use those plus the Nightly responsive files for your styling option.

    Kevin

  • colincolin Posts: 9,834Questions: 0Answers: 1,632

    Yep, agreed, this is a big one. We're aiming on pushing a release for this issue this week.

    Colin

  • allanallan Posts: 52,715Questions: 1Answers: 8,069 Site admin

    Yup - release coming up!

    Allan

  • allanallan Posts: 52,715Questions: 1Answers: 8,069 Site admin

    That's 2.2.5 tagged and on the download builder now. npm packages building just now.

    Allan

  • rf1234rf1234 Posts: 1,770Questions: 51Answers: 259

    Allan, Colin, Kevin! You saved my day! Just installed the new version: Works!!!
    No complaints tomorrow morning (won't be available anyway)... This is awesome!

    Thanks a lot!!! You guys are a great team!

    Roland

Sign In or Register to comment.