Feature Plugin Feedback

Gage

I've been using Datatables 2 for over two years now and wanted to try making a real feature plugin.
This plugin is very similar to the idea of searchPanels plugin but with different styling etc.
This plugin is mainly to test and expand my knowledge so I'm looking for feedback for my design, layout, methodology, best practices, and anything else you can think about.

This is not a request to have this added as an official Datatabes plugin.

Thanks

Requirements:
JQuery 3.7.1
Datatables 2.3.5 (Bootstrap 5 styling)
Bootstrap 5
Bootstrap Icons

https://live.datatables.net/fobiguka/4/watch?js

For some reason the Javascript compiler on here does not like the code

kthorngren

The example runs by clicking the Live preview button, the upward / right facing arrow in the top left of the Output tab. The problem is the Edit in JS Bin button that appears on the upper right of this page, covering your plugin button. I changed the layout option to allow seeing your button:
https://live.datatables.net/qiyarumo/1

It took a bit to understand what the four buttons next to the search inputs are for.

Maybe one thing I would do is add a Close button and leave the plugin open after clicking Apply. I would look at using info to update an info display element placed in the plugin window. This way the user can get a sense of what the table is displaying before closing the plugin window in case any changes are need. For example if, after searching, there are 0 records displayed but the expectation is to have some rows displayed the user can update the search terms without needing to reopen the plugin.

The plugin seems to work well. I haven't looked through the code though. My Javascript skills are mediocre at best so I'm not the best person to evaluate other's code. Maybe @allan will have time to evaluate your plugin further.

Great job!

Kevin

Gage

My bad I forgot to add the bootstrap icons link in the html
That should at least fix the issue of not knowing what the buttons do.

I like changing the cancel to a close button. I also see now that I need to clear any selected items when the modal is closed and not saved. And I agree if the modal doesn't close automatically I could show some sort of count of the tables rows for the user.

I appreciate the feedback!

https://live.datatables.net/soyijaye/2/edit

allan

Excellent work! I think that looks very impressive. The only feedback from me would be to change the colour of the filter icon depending on if a filter is applied or not (or show some other visual indication).

Allan